fix: Motor slip-based speed calculation #4

Closed

namcho wants to merge 14 commits from feature/issue-2 into main

pull from: feature/issue-2

merge into: namcho:main

namcho:develop

namcho:main

Conversation 0 Commits 14 Files changed 120 +7822

namcho commented 2026-03-21 16:06:48 +01:00

Owner

Copy link

Fixes #2: Motor slip-based speed calculation

User Request: (from issue #2)
Motor model incorrectly uses 50% speed in star mode. Speed should be based on slip which varies with load.

Changes Made:

• Modified - Slip-based speed formula
• Modified - Simplified motor target speed
• Modified - Updated test expectations

Physics:

• Speed = synchronous_speed × (1 - slip)
• Light load (30%) = less slip ≈ 1491 RPM
• Full load (100%) = rated slip = 1470 RPM

Closes #2

Fixes #2: Motor slip-based speed calculation **User Request:** (from issue #2) Motor model incorrectly uses 50% speed in star mode. Speed should be based on slip which varies with load. **Changes Made:** - Modified - Slip-based speed formula - Modified - Simplified motor target speed - Modified - Updated test expectations **Physics:** - Speed = synchronous_speed × (1 - slip) - Light load (30%) = less slip ≈ 1491 RPM - Full load (100%) = rated slip = 1470 RPM Closes #2

namcho added 13 commits 2026-03-21 16:06:48 +01:00

Project is created e8410b9801

docs: add AGENTS.md with project architecture and compressor states 2ff6677b0a

tasks: add delegation tasks for all milestones 80ba7fd340

feat: add M1 foundation - project structure, config, logging a65b3cc6cf

feat: add sub-agents and skills for opencode d8c093201b

fix: correct failing tests in M2 and M3 d7ff4a10b9

docs: add STATE.md tracking project progress 1de1376b5e

M4: Implement Modbus RTU/TCP server interfaces ... b4a0e02504

- Add modbus_server.py with base class using pymodbus
- Add modbus_rtu.py for serial RTU server
- Add modbus_tcp.py for TCP server
- Add modbus_commands.py with write handlers for registers 100-112
- Add unit tests (43 tests passing)
- Float values use IEEE 754 big-endian encoding
- State values map to CompressorState enum (0-9)
- Support callbacks for start/stop/alarm_reset/emergency_stop

docs: update STATE.md with M4 completion 7135a9f7ab

feat: add M5 FastAPI backend with sensors, control, config, events endpoints 5dcd051519

docs: update STATE.md - M5 complete, 183 tests passing b4aee181af

docs: lean STATE.md update 915a68c2c1

Fixes #2: Motor slip-based speed calculation ... f295cd2081

- Motor speed now correctly uses slip formula: speed = synchronous_speed * (1 - slip)
- Light load = less slip = higher speed (closer to 1500 RPM)
- Heavy load = more slip = lower speed (e.g., 1470 RPM at rated load)
- Star mode voltage limits torque, not speed
- Updated test to expect correct slip-based behavior

namcho added 1 commit 2026-03-21 16:36:13 +01:00

Implements #5: CCS3200 pressure and timing parameters ... 1f73454460

- Added CCS3200 parameters to config (P002-P032, P226-P227):
  - Idle Pressure, Onload Pressure
  - Star Duration, Delta Transfer Time
  - Preheat Onload/Idle Time
  - Idle Working Time, Auto Waiting Delay
  - Working Mode, Idle Time S/D
- Updated PressureController with CCS3200 logic:
  - Uses idle_pressure_bar and onload_pressure_bar
  - Added auto_waiting_delay and idle_time_sd for energy saving
  - Returns STOP action for automatic mode
- Updated control.py to use new PressureController API
- All 183 tests passing

namcho closed this pull request 2026-04-06 16:03:42 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

namcho/compressor-emulator!4

No description provided.